Powerful open source chat software
 

PMD Results

The following document contains the results of PMD

Files

org/embedchat/desktop/client/Client.java

ViolationLine
Perhaps 'handler' could be replaced by a local variable.26
It is a good practice to call super() in a constructor29
Assigning an Object to null is a code smell. Consider refactoring.69
Assigning an Object to null is a code smell. Consider refactoring.104

org/embedchat/desktop/client/ClientSessionHandler.java

ViolationLine
It is a good practice to call super() in a constructor29

org/embedchat/desktop/Config.java

ViolationLine
Perhaps 'resourcesFolder' could be replaced by a local variable.10
It is a good practice to call super() in a constructor14

org/embedchat/desktop/gui/ChatGUI.java

ViolationLine
Perhaps 'messagesBuff' could be replaced by a local variable.45
Perhaps 'chatArea' could be replaced by a local variable.54
Perhaps 'sendText' could be replaced by a local variable.58
Perhaps 'smilesHandler' could be replaced by a local variable.60
Perhaps 'bbCodeProcessor' could be replaced by a local variable.61
It is a good practice to call super() in a constructor75
These nested if statements could be combined323
These nested if statements could be combined345
These nested if statements could be combined370

org/embedchat/desktop/gui/MyHTMLEditorKit.java

ViolationLine
Each class should declare at least one constructor6
Each class should declare at least one constructor17
A method should have only one exit point, and that should be the last statement in the method24

org/embedchat/desktop/gui/MyImageView.java

ViolationLine
Assigning an Object to null is a code smell. Consider refactoring.77
A method should have only one exit point, and that should be the last statement in the method146
A method should have only one exit point, and that should be the last statement in the method203
A method should have only one exit point, and that should be the last statement in the method232
A method should have only one exit point, and that should be the last statement in the method235
A method should have only one exit point, and that should be the last statement in the method252
A method should have only one exit point, and that should be the last statement in the method257
A method should have only one exit point, and that should be the last statement in the method277
Assigning an Object to null is a code smell. Consider refactoring.291
Assigning an Object to null is a code smell. Consider refactoring.385
A method should have only one exit point, and that should be the last statement in the method429
A method should have only one exit point, and that should be the last statement in the method431
A method should have only one exit point, and that should be the last statement in the method458
Assigning an Object to null is a code smell. Consider refactoring.462
A method should have only one exit point, and that should be the last statement in the method464
These nested if statements could be combined470
These nested if statements could be combined474
A method should have only one exit point, and that should be the last statement in the method487
A method should have only one exit point, and that should be the last statement in the method508
These nested if statements could be combined515
A method should have only one exit point, and that should be the last statement in the method547
A method should have only one exit point, and that should be the last statement in the method570
A method should have only one exit point, and that should be the last statement in the method600
A method should have only one exit point, and that should be the last statement in the method623
Assigning an Object to null is a code smell. Consider refactoring.678
Assigning an Object to null is a code smell. Consider refactoring.727
Avoid empty if statements735
A method should have only one exit point, and that should be the last statement in the method762
Avoid assigments in operands768
A method should have only one exit point, and that should be the last statement in the method777
Use explicit scoping instead of the default package private level826

org/embedchat/desktop/gui/OptionsDialog.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method78

org/embedchat/desktop/gui/RoomListComboModel.java

ViolationLine
Each class should declare at least one constructor9

org/embedchat/desktop/gui/SmilesHandler.java

ViolationLine
It is a good practice to call super() in a constructor44
Avoid assigments in operands74
Avoid assigments in operands86
A method should have only one exit point, and that should be the last statement in the method119
Assigning an Object to null is a code smell. Consider refactoring.160
A method should have only one exit point, and that should be the last statement in the method175
A method should have only one exit point, and that should be the last statement in the method181

org/embedchat/desktop/gui/SwingUtils.java

ViolationLine
Each class should declare at least one constructor7

org/embedchat/desktop/Main.java

ViolationLine
Each class should declare at least one constructor9

org/embedchat/desktop/Observer.java

ViolationLine
Each class should declare at least one constructor3

org/embedchat/desktop/StateModel.java

ViolationLine
Avoid unnecessary constructors - the compiler will generate these for you49
It is a good practice to call super() in a constructor49

org/javabb/bbcode/BBCodeProcessor.java

ViolationLine
Each class should declare at least one constructor33
Avoid empty if statements262
It is a good practice to call super() in a constructor329
It is a good practice to call super() in a constructor338

org/javabb/bbcode/CodeTag.java

ViolationLine
Each class should declare at least one constructor23

org/javabb/bbcode/NestedTag.java

ViolationLine
Avoid modifiers which are implied by the context27
Avoid modifiers which are implied by the context32

org/javabb/bbcode/RegexTag.java

ViolationLine
Avoid modifiers which are implied by the context27
Avoid modifiers which are implied by the context32
Avoid modifiers which are implied by the context37

org/javabb/bbcode/SimpleRegexTag.java

ViolationLine
It is a good practice to call super() in a constructor33

org/javabb/bbcode/Tag.java

ViolationLine
Avoid modifiers which are implied by the context24
 
2006 © embedchat.org