Powerful open source chat software
 

PMD Results

The following document contains the results of PMD

Files

org/embedchat/protocol/codec/AbstractMessageDecoder.java

ViolationLine
Perhaps 'readHeader' could be replaced by a local variable.15
It is a good practice to call super() in a constructor17
A method should have only one exit point, and that should be the last statement in the method24
A method should have only one exit point, and that should be the last statement in the method31
A method should have only one exit point, and that should be the last statement in the method47

org/embedchat/protocol/codec/AbstractMessageEncoder.java

ViolationLine
It is a good practice to call super() in a constructor14

org/embedchat/protocol/codec/ChatProtocolCodecFactory.java

ViolationLine
It is a good practice to call super() in a constructor20

org/embedchat/protocol/codec/client/LoginMessageDecoder.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method22
A method should have only one exit point, and that should be the last statement in the method33

org/embedchat/protocol/codec/client/RoomsListRequestMessageDecoder.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method22
A method should have only one exit point, and that should be the last statement in the method31

org/embedchat/protocol/codec/common/TextMessageDecoder.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method22
A method should have only one exit point, and that should be the last statement in the method32

org/embedchat/protocol/codec/server/ErrorMessageDecoder.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method23
A method should have only one exit point, and that should be the last statement in the method33

org/embedchat/protocol/codec/server/RoomsListMessageDecoder.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method23
A method should have only one exit point, and that should be the last statement in the method35

org/embedchat/protocol/codec/server/UsersListMessageDecoder.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method23
A method should have only one exit point, and that should be the last statement in the method35

org/embedchat/protocol/Constants.java

ViolationLine
It is a good practice to call super() in a constructor40

org/embedchat/protocol/message/AbstractMessage.java

ViolationLine
Each class should declare at least one constructor5

org/embedchat/protocol/message/client/LoginMessage.java

ViolationLine
Each class should declare at least one constructor18
A method should have only one exit point, and that should be the last statement in the method68

org/embedchat/protocol/message/client/RoomsListRequestMessage.java

ViolationLine
Each class should declare at least one constructor8
A method should have only one exit point, and that should be the last statement in the method36

org/embedchat/protocol/message/common/TextMessage.java

ViolationLine
Each class should declare at least one constructor7
A method should have only one exit point, and that should be the last statement in the method43

org/embedchat/protocol/message/server/ErrorMessage.java

ViolationLine
Each class should declare at least one constructor18
A method should have only one exit point, and that should be the last statement in the method70

org/embedchat/protocol/message/server/RoomsListMessage.java

ViolationLine
Each class should declare at least one constructor22
A method should have only one exit point, and that should be the last statement in the method56
It is a good practice to call super() in a constructor71
A method should have only one exit point, and that should be the last statement in the method101

org/embedchat/protocol/message/server/UsersListMessage.java

ViolationLine
Each class should declare at least one constructor25
A method should have only one exit point, and that should be the last statement in the method59
A method should have only one exit point, and that should be the last statement in the method83
It is a good practice to call super() in a constructor95
 
2006 © embedchat.org